Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes dmsg showing 00000 after successful reconnection #980

Merged
merged 3 commits into from
Oct 28, 2021
Merged

fixes dmsg showing 00000 after successful reconnection #980

merged 3 commits into from
Oct 28, 2021

Conversation

alexadhy
Copy link
Contributor

Did you run make format && make check? yes

Fixes #972

Changes:

  • Re-initialize dmsgtracker after reconnection

How to test this PR:

  • Run one machine as hypervisor, and another as visor managed by that hypervisor
  • Disconnect hypervisor's internet connection
  • See UI on dmsg list (http://localhost:8000/#/nodes/dmsg/1)
  • Check that the dmsg server reverts to 00000
  • reconnect the hypervisor to the internet
  • refresh the list from the UI / fetch visors-summary endpoint from curl / postman
  • you'll see that there's no 00000 anymore.

@jdknives jdknives merged commit c08d224 into skycoin:develop Oct 28, 2021
@alexadhy alexadhy deleted the fix/dmsgsummary-tracker branch November 23, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexadhy @jdknives